Add warning when initializing a substituted model #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
commented
Jun 8, 2021
| rng_key = site["kwargs"].get("rng_key") | ||
| sample_shape = site["kwargs"].get("sample_shape") | ||
| rng_key, subkey = random.split(rng_key) |
There was a problem hiding this comment.
the subkey is not used so we don't need this line
fehiepsi
commented
Jun 22, 2021
fritzo
reviewed
Jun 23, 2021
|
Seems like a good idea; we should do this in Pyro too! |
4 tasks
|
@fritzo Could you help me review this pr? |
fritzo
approved these changes
Sep 25, 2021
|
Thanks, Fritz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1057. For a substituted site,
rng_keyis not available (becauseseedhandler knows that this site already has some value) so we can't generate a new init value. This PR adds a warning and in that case, the init strategy will return the substituted value.I also fixed some doc formatting issues and added a note to
substitutedocstring regarding conditioning.cc @llaurabat91