-
Notifications
You must be signed in to change notification settings - Fork 479
Much more user-friendly handling of pip errors during pipx install
#625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to merge this soon if nobody has any comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.md
Summary of changes
This stops streaming all pip errors to the shell when
pipx install
fails due to pip errors. Instead, it~/.local/pipx/logs
Currently when
pipx install
fails, we stream the entire pip stderr output to the shell. This can easily be an overwhelming mass of text, in some cases over 1900 lines long. This is not user-friendly.Closes #613
Test plan
Here is a comparison of trying to execute
pipx install mayan-edms==3.5.2
on macOSThis PR:
pipx 0.16.0.0 (current behavior):