Skip to content

fix: resolve the DEFAULT_PYTHON to the actual absolute path #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: resolve the DEFAULT_PYTHON to the actual absolute path #1340

merged 1 commit into from
Apr 11, 2024

Conversation

huxuan
Copy link
Member

@huxuan huxuan commented Apr 11, 2024 •
edited
Loading

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fix #965

Use the resolved absolute path for DEFAULT_PYTHON can change the default python of pipx-managed pipx from /usr/local/pipx/venvs/pipx/bin/python to /usr/bin/python3.10. In this way, pipx reinstall-all will work for pipx-managed pipx.

Test plan

Tested by running

# command(s) to exercise these changes
pipx install pipx
pipx reinstall-all

@huxuan huxuan marked this pull request as ready for review April 11, 2024 08:18
@huxuan huxuan marked this pull request as draft April 11, 2024 08:18
@huxuan huxuan marked this pull request as ready for review April 11, 2024 09:08
@dukecat0 dukecat0 merged commit 49c9983 into pypa:main Apr 11, 2024
@huxuan huxuan deleted the xuan.hu/resolve-default-python branch April 12, 2024 01:04
@huxuan huxuan mentioned this pull request Jun 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reinstall-all reinstalls everything but pipx
3 participants
@huxuan @uranusjr @dukecat0