Skip to content

Update requirement specification #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 6, 2024
Merged

Update requirement specification #1240

merged 4 commits into from
Feb 6, 2024

Conversation

oberbichler
Copy link
Contributor

@oberbichler oberbichler commented Feb 3, 2024 •
edited by chrysle
Loading

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Test plan

Tested by running

# test.py

# /// script
# dependencies = ["requests"]
# ///

import sys
import requests
project = sys.argv[1]
pipx_data = requests.get(f"https://pypi.org/pypi/{project}/json").json()
print(pipx_data["info"]["version"])

with

pipx run test.py

Gitznik
Gitznik requested changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. Could you please add a doc news fragment according to our contribution guidelines?

@oberbichler
Copy link
Contributor Author

Done

@chrysle
Copy link
Contributor

chrysle commented Feb 3, 2024

Please also mention that the requirement specification syntax comes from the inline script metadata specification.

@chrysle chrysle added the awaiting response Awaiting re-engagement by contributor label Feb 4, 2024
@Gitznik Gitznik mentioned this pull request Feb 5, 2024
Closed
1 task
@Gitznik
Copy link
Contributor

Gitznik commented Feb 5, 2024

Please also mention that the requirement specification syntax comes from the inline script metadata specification.

As per @katrinafyi in #1244:

If you have a script `test.py` that needs 3rd party libraries,
you can add [inline script metadata](https://packaging.python.org/en/latest/specifications/inline-script-metadata/)
in the style of PEP 723.

@oberbichler
Copy link
Contributor Author

Done

Gitznik
Gitznik approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@Gitznik Gitznik removed the awaiting response Awaiting re-engagement by contributor label Feb 6, 2024
@chrysle chrysle merged commit c2df428 into pypa:main Feb 6, 2024
@chrysle
Copy link
Contributor

chrysle commented Feb 6, 2024

Thanks!

@oberbichler oberbichler deleted the patch-1 branch February 7, 2024 07:52
@lishaduck lishaduck mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gitznik Gitznik Gitznik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipx fails to run script with dependencies.
3 participants
@oberbichler @chrysle @Gitznik