Pass --no-input #1029
Merged
Pass --no-input #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e0e6ba to
fdc4967
Compare
uranusjr
reviewed
Aug 2, 2023
uranusjr
reviewed
Aug 10, 2023
src/pipx/venv.py
Outdated
Comment on lines
304
to
308
| cmd = ( | ||
| ["--no-input", "install", "--no-dependencies"] | ||
| + pip_args | ||
| + [package_or_url] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| cmd = ( | |
| ["--no-input", "install", "--no-dependencies"] | |
| + pip_args | |
| + [package_or_url] | |
| ) | |
| cmd = [ | |
| "--no-input", | |
| "install", | |
| "--no-dependencies", | |
| *pip_args, | |
| package_or_url, | |
| ] |
We should probably use this chance to change other command-building code as well.
There was a problem hiding this comment.
I left some in the form of cmd = [<snip>] + cmd alone instead of changing it to cmd = [<snip>, *cmd].
uranusjr
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Pass
--no-inputto Pip.Fixes #219
This is a breaking change for keyring users. But was it ever properly supported anyway? As someone who needs the
artifacts-keyringpackage to authenticate with our private repo I'm going with the answer beingno, you will have to apply hacks if this is important to you. Failing fast is better then hanging forever because the user can't see the prompt asking for a username and password.pypa/pip#11698 which is released in Pip 23.1 added a section to the documentation how Pipx users who rely on the keyring library can set things up so keyring will be used again: https://pip.pypa.io/en/stable/topics/authentication/#using-keyring-as-a-command-line-application.
Test plan
It should not have any impact when keyring is not required to authenticate with the repository.
Tested by running the test suite.