Skip to content

Conversation

huxuan
Copy link
Member

@huxuan huxuan commented Jun 1, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Fix release tag creation, the mathieudutour/github-tag-action will create v1.6.0 rather than 1.6.0 which causes the broken of release workflow

Test plan

Tested by running

# command(s) to exercise these changes

@huxuan huxuan marked this pull request as draft June 1, 2024 23:28
@huxuan huxuan marked this pull request as ready for review June 2, 2024 00:11
@dukecat0 dukecat0 added the release-version Given to PRs that should trigger CD label Jun 2, 2024
@dukecat0 dukecat0 merged commit f27c3fc into pypa:main Jun 2, 2024
@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

@dukecat0 The version was missing from the PR title...

@chrysle chrysle changed the title fix: fix release tag creation 1.6.0: fix release tag creation Jun 2, 2024
@dukecat0
Copy link
Member

dukecat0 commented Jun 2, 2024

Thanks for the heads up 😅

@dukecat0
Copy link
Member

dukecat0 commented Jun 2, 2024

Maybe we need to add workflow_dispatch: to trigger the deployment manually?

@dukecat0 dukecat0 added release-version Given to PRs that should trigger CD and removed release-version Given to PRs that should trigger CD labels Jun 2, 2024
@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

Sounds good, it's getting quite annoying now.

@chrysle
Copy link
Contributor

chrysle commented Jun 2, 2024

Can't delete the wrong tags created, by the way.

@dukecat0
Copy link
Member

dukecat0 commented Jun 2, 2024

I just opened #1436 for this.

@dukecat0
Copy link
Member

dukecat0 commented Jun 2, 2024

Can't delete the wrong tags created, by the way.

I just deleted those two wrong tags with CLI.

@huxuan huxuan deleted the xuan.hu/fix-release branch June 2, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version Given to PRs that should trigger CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants