Skip to content

Error logs overwrite each other when using reinstall-all #1132

@corneliusroemer

Description

@corneliusroemer

Describe the bug

When running pipx reinstall-all --python "python3.12" and getting error logs from multiple reinstallations, the logs are overwritten.

Each reinstallation should get its own log path, or logs should be appended to and not overwritten.

How to reproduce

  1. Run a command that errors for multiple installations, e.g (via When upgrading package to Python 3.12: Fatal error: TypeError: rmtree() got an unexpected keyword argument 'onexc' #1090)
pipx install visidata pycowsay --python "3.11"
pipx reinstall-all --python "3.12"
  1. Check out the error logs for earlier errors, i.e. /Users/USERNAME/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

Expected behavior

The logs are appended to, rather than overwritten.

Details

This is the terminal output I get:

 pipx reinstall-all --python "python3.12"
uninstalled parquet-cli! ✨ 🌟 ✨
Fatal error from pip prevented installation. Full pip output in file:
    /Users/corneliusromer/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

pip seemed to fail to build package:
    six>=1.5

Some possibly relevant errors from pip install:
    TypeError: rmtree() got an unexpected keyword argument 'onexc'

Error installing parquet-cli.
uninstalled hatch! ✨ 🌟 ✨
Fatal error from pip prevented installation. Full pip output in file:
    /Users/corneliusromer/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

pip seemed to fail to build package:
    more-itertools

Some possibly relevant errors from pip install:
    TypeError: rmtree() got an unexpected keyword argument 'onexc'

Error installing hatch.
uninstalled pycowsay! ✨ 🌟 ✨
Fatal error from pip prevented installation. Full pip output in file:
    /Users/corneliusromer/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

pip seemed to fail to build package:
    pycowsay

Some possibly relevant errors from pip install:
    TypeError: rmtree() got an unexpected keyword argument 'onexc'

Error installing pycowsay.
uninstalled chatGPT! ✨ 🌟 ✨
Fatal error from pip prevented installation. Full pip output in file:
    /Users/corneliusromer/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

pip seemed to fail to build package:
    git+https://github.com/mmabrouk/chatgpt-wrapper

Some possibly relevant errors from pip install:
    TypeError: rmtree() got an unexpected keyword argument 'onexc'

Error installing chatGPT from spec 'git+https://github.com/mmabrouk/chatgpt-wrapper'.
uninstalled datasette! ✨ 🌟 ✨
Fatal error from pip prevented installation. Full pip output in file:
    /Users/corneliusromer/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

pip seemed to fail to build package:
    MarkupSafe>=2.0

Some possibly relevant errors from pip install:
    TypeError: rmtree() got an unexpected keyword argument 'onexc'

Error installing datasette.
The following package(s) failed to reinstall: parquet-cli, hatch, pycowsay, chatgpt, datasette

Note that all the error file paths are the same: /Users/corneliusromer/.local/pipx/logs/cmd_2023-12-03_14.10.06_pip_errors.log

When I open that file, I see only error output from the last command invoked, earlier error logs are overwritten.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions