Fix: Windows long filename error #13490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @ichard26, Would you mind taking a look at this and merging it if everything looks good? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13346.
Hi @ichard26,
I opened a new PR since the previous one became a bit messy due to my mistake, really sorry for that. I’ll make sure to keep things cleaner moving forward. This PR includes everything from the last one, along with the changes you requested.
Thanks again for your time and support, I appreciate it. Would you mind taking a look?
Edit: All integration tests on any PR is now failing because of a hardcoded SHA, I've made a PR specifically for that.