Enable resumable downloads by default #13464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
approved these changes
Jul 7, 2025
|
I'm likely going to include this for the 25.2 release. I'm not going to have much time after August to deal with any regressions, so it's preferable to deal with them now when I have the capacity to do so then force someone else to pick it during the 25.3 release cycle. I don't think there will be any major issues, either way. This logic is well pretty tested. |
|
I did more manual testing with the resume + caching logic. I couldn't get it to fail, so I'll merge this now. |
|
Awesome to see this land! Also tested that everything works correctly. @ichard26 @notatallshaw Great work and thank you for your efforts! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13398. If anyone has concerns with the fact that there were two major changes to this functionality during this development cycle, please let me know: