Skip to content

Conversation

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 21, 2023 20:55
@edgarrmondragon edgarrmondragon marked this pull request as draft December 21, 2023 22:33
@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 21, 2023 23:46
@brettcannon brettcannon self-requested a review January 4, 2024 21:04
@edgarrmondragon
Copy link
Contributor Author

I believe I've addressed all the feedback, so let me know if you'd like to see other changes

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc tweak to align w/ what the TypedDict is being used for.

Co-authored-by: Brett Cannon <brett@python.org>
@brettcannon
Copy link
Member

@pradyunsg you good w/ this approach of a TypedDict for the specific return type?

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this will need a rebase due to #783 dropping 3.7 support (which requires changes to _typing.py introduced here).

@edgarrmondragon
Copy link
Contributor Author

I took the liberty of bumping the required Python version in RTD to 3.9, since that's also the version specified for the docs Nox session.

@brettcannon brettcannon merged commit e0dda88 into pypa:main Mar 11, 2024
@brettcannon
Copy link
Member

Thanks, @edgarrmondragon !

@edgarrmondragon edgarrmondragon deleted the document-default-environment branch March 12, 2024 02:42
kodiakhq bot referenced this pull request in cloudquery/plugin-sdk-python Jul 1, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [packaging](https://togithub.com/pypa/packaging) | minor | `==24.0` -> `==24.1` |

---

### Release Notes

<details>
<summary>pypa/packaging (packaging)</summary>

### [`v24.1`](https://togithub.com/pypa/packaging/releases/tag/24.1)

[Compare Source](https://togithub.com/pypa/packaging/compare/24.0...24.1)

#### What's Changed

-   pyupgrade/black/isort/flake8 → ruff by [@&#8203;DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) in [https://github.com/pypa/packaging/pull/769](https://togithub.com/pypa/packaging/pull/769)
-   Add support for Python 3.13 and drop EOL 3.7 by [@&#8203;hugovk](https://togithub.com/hugovk) in [https://github.com/pypa/packaging/pull/783](https://togithub.com/pypa/packaging/pull/783)
-   Bump the github-actions group with 4 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/pypa/packaging/pull/782](https://togithub.com/pypa/packaging/pull/782)
-   Fix typo in `_parser` docstring by [@&#8203;pradyunsg](https://togithub.com/pradyunsg) in [https://github.com/pypa/packaging/pull/784](https://togithub.com/pypa/packaging/pull/784)
-   Modernise type annotations using FA rules from ruff by [@&#8203;pradyunsg](https://togithub.com/pradyunsg) in [https://github.com/pypa/packaging/pull/785](https://togithub.com/pypa/packaging/pull/785)
-   Document `markers.default_environment()` by [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) in [https://github.com/pypa/packaging/pull/753](https://togithub.com/pypa/packaging/pull/753)
-   Bump the github-actions group with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/pypa/packaging/pull/789](https://togithub.com/pypa/packaging/pull/789)
-   Work around platform.python_version() returning non PEP 440 compliant version for non-tagged CPython builds by [@&#8203;sbidoul](https://togithub.com/sbidoul) in [https://github.com/pypa/packaging/pull/802](https://togithub.com/pypa/packaging/pull/802)

#### New Contributors

-   [@&#8203;dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/pypa/packaging/pull/782](https://togithub.com/pypa/packaging/pull/782)
-   [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) made their first contribution in [https://github.com/pypa/packaging/pull/753](https://togithub.com/pypa/packaging/pull/753)

**Full Changelog**: pypa/packaging@24.0...24.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document markers.default_environment() and specify its return type via a TypedDict Document markers.default_environment()
3 participants