Skip to content

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Nov 4, 2019

Introduce a separate PR for patch alias as discussed in #225 (comment)

@fridex
Copy link
Contributor Author

fridex commented Nov 8, 2019

Friendly ping? Any progress on this one?

@brettcannon
Copy link
Member

@fridex I think we're all unfortunately just really busy at the moment.

@fridex
Copy link
Contributor Author

fridex commented Nov 8, 2019

@fridex I think we're all unfortunately just really busy at the moment.

Sure, no rush.

@di
Copy link
Member

di commented Nov 8, 2019

@fridex Can you remove the extra commit here now that #225 is merged?

I believe @pradyunsg was the one with reservations about a .patch() alias -- care to comment?

@fridex fridex force-pushed the introduce-patch-version-alias branch from 28a6a2b to 2de901e Compare November 8, 2019 18:46
@pradyunsg
Copy link
Member

pradyunsg commented Feb 6, 2020

Thanks y'all for the patience with a vanishing-me.

Since these names are not the same as SemVer, I'm pretty sure that wouldn't be a source of confusion when using this API.

My only concern with this change was that PEP 440 isn't fully compatible with SemVer, and the semantics of the two are slightly different in some edge cases.

By using API nomenclature that's not exactly the same as SemVer, we've avoided baking an assumption that the user knows that packaging's Versions (i.e. PEP 440 versions) are the same as SemVer's versions. Using the exact same names as SemVer, indirectly hints at PEP440 being a super-set of or fully compatible with SemVer, which isn't correct and I prefer that we avoid this if we can -- which we can in this case IMO.


In other words: Given that we already provide this functionality, IMO it is not a good idea to add more API-surface-area to Version for adding vocabulary from a standard that we don't actually comply with (SemVer), while implying that we do (indirectly via the naming).

@brettcannon
Copy link
Member

I agree with the logic @pradyunsg provided, so I'm going to close this (if other maintainers disagree we can obviously reopen the PR).

Thanks for creating the PR and sparking the discussion, @fridex .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants