fix: Fix ModuleNotFoundError when pip is not installed
#898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the exception raised if `pip` is not installed at all:
```
[...]
File "/usr/lib/python3.14/site-packages/build/env.py", line 168, in _has_valid_outer_pip
if importlib.util.find_spec('pip._vendor') is None:
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "<frozen importlib.util>", line 90, in find_spec
ModuleNotFoundError: No module named 'pip'
```
This is a regression from pypa#861 where I did not predict that
`find_spec()` will actually raise when the parent package
is not available. To fix it, just reorder the conditions to make sure
that `pip` is installed first.
301b492 to
5480b7c
Compare
|
Ah, I think this was a regression in an unreleased change? Best kind of fix. :) |
henryiii
reviewed
May 21, 2025
gaborbernat
approved these changes
May 21, 2025
Yeah, fortunately I've backported it to Gentoo and managed to notice while we were doing the Python 3.14 testing. Sorry about it and thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the exception raised if
pipis not installed at all:This is a regression from #861 where I did not predict that
find_spec()will actually raise when the parent package is not available. To fix it, just reorder the conditions to make sure thatpipis installed first.