Skip to content

feat: CIBW_DEBUG_KEEP_CONTAINER: debug container after build #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2023
Merged

feat: CIBW_DEBUG_KEEP_CONTAINER: debug container after build #1620

merged 4 commits into from
Oct 3, 2023

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Sep 19, 2023

closes #1320. With this flag enabled, the containers of local (failing) builds can be debugged afterwards.

@Helveg Helveg mentioned this pull request Sep 19, 2023
Closed
henryiii
henryiii reviewed Sep 19, 2023
View reviewed changes
henryiii
henryiii reviewed Sep 19, 2023
View reviewed changes
@Helveg Helveg requested review from henryiii and joerick September 19, 2023 17:40
@henryiii henryiii changed the title feature: CIBW_DEBUG_KEEP_CONTAINER option. debug container after build feat: CIBW_DEBUG_KEEP_CONTAINER: debug container after build Oct 3, 2023
joerick
joerick approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda seeing options like this as tier-2 options, as they're for debugging purposes only, we don't need to be too strict around requiring tests etc.

@joerick joerick merged commit 9da4ede into pypa:main Oct 3, 2023
@Helveg
Copy link
Contributor Author

Helveg commented Oct 4, 2023 •
edited
Loading

@joerick I also think the tests are merely failing because you've reached your CI quota with your CI provider:

⚠️ Failed to start an instance: FAILED_PRECONDITION: Monthly free compute limit exceeded!

The first commit was still succeeding

@Helveg Helveg deleted the cibw-debug-keep-container branch October 4, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerick joerick joerick approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to leave OCI container alive for debugging after build
3 participants
@Helveg @joerick @henryiii