slider angle #197
slider angle #197
Conversation
|
Whoa! So many good news! :) That's great. I'm merging this in! As we fixed the multi-system pipeline I now hopefully be now able to do gradual releases. Regarding the python-only demo, that's wonderful. People requested it numerous times and started their work but we haven't merged anything substantial yet as it was often incomplete work. Keep in mind that I plan to merge #192 this week and do a pre-release of imgui 2.0.0. That version will have some backward incompatible changes as it migrates to latest imgui version. You may want to check it out to make sure your deo will be compatible. Thank you for buying the book :). I hope it will serve you well. |
|
Great news, python-based demo was on my todo list for the 2.0.0 upgrade, and a little help with it would be fantastic. It is excellent that you implement missing controls, but be aware of the changes coming. I am currently working on the upgrade from Imgui 1.65 to 1.79 (#192). As @swistakm said, this change has some backward incompatibilities, and you should be careful. Numerous functions have changed name or input arguments, some default values changed too, and many new flags have been added. Moreover, many controls have already been mapped for this new version, including SliderAngle(). Maybe we should coordinate our work a little bit to avoid repeating work? I merged your implementation of SliderAngle() with mine, but we didn't do it very differently. I kept the documentation describing the difference between angle format taken as input (radian vs degree), default values, and new SliderFlag input. Let me know if I have forgotten something. |
|
Sorry for my delay in responding.
Thanks for reaching out, that sounds good. Right now I'm trying to just go
for low hanging fruit in the demo, so I'll minimize the implementation of
extra controls (i.e. stuff not already implemented, like sliderangle), and
Ill take a look at your branch as well to minimize duplicated work.
I just submitted a PR for my demo into master. It's got most of the common
controls, and about 50 to 60% of the demo converted.
…On Mon, Dec 21, 2020, 10:24 AM KinoxKlark ***@***.***> wrote:
Great news, python-based demo was on my todo list for the 2.0.0 upgrade,
and a little help with it would be fantastic.
It is excellent that you implement missing controls, but be aware of the
changes coming. I am currently working on the upgrade from Imgui 1.65 to
1.79 (#192 <#192>). As @swistakm
<https://github.com/swistakm> said, this change has some backward
incompatibilities, and you should be careful. Numerous functions have
changed name or input arguments, some default values changed too, and many
new flags have been added. Moreover, many controls have already been mapped
for this new version, including SliderAngle(). Maybe we should coordinate
our work a little bit to avoid repeating work?
I merged your implementation of SliderAngle() with mine, but we didn't do
it very differently. I kept the documentation describing the difference
between angle format taken as input (radian vs degree), default values, and
new SliderFlag input. Let me know if I have forgotten something.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGK5SCTGOYZJFYTHCCKYITSV5SBXANCNFSM4VCOWYSA>
.
|
Implements the slider angle control.
FYI -- I'm working on making python demo code that calls all of the imgui widgets via python, whereas pyimgui's demos currently defaults to calling the C++ implementation of the demos, which makes copying and pasting demo code difficult for Python programmers who may not know C++. As part of this work of mine, I am implementing any missing controls, such as slider angle, and I plan to incrementally send over those implementations via PRs into master as I make them.
My implementation of the python-based demo is at https://github.com/billsix/pyimgui/tree/implementDemos . Once I have implemented the full set, I plan to do a squash merge into master, and send the one final pull request for those demos. The reason for this method is to to minimize commits of partial work that I make, which I expect to be 20+ commits of incomplete work, and instead provide 1 complete commit into your master.
However, a commit such as what I've attached is complete work, as it implements slider_control, so I believe that it should be in its own commit in master.
I just bought your book yesterday to support the good work that you are doing. Thank you.