fix: fix x86 Windows build #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 47.84% 47.46% -0.38%
==========================================
Files 26 26
Lines 1783 1797 +14
==========================================
Hits 853 853
- Misses 930 944 +14 ☔ View full report in Codecov by Sentry. |
qryxip
added a commit
to qryxip/ort
that referenced
this pull request
Jun 24, 2024
Hiroshiba
pushed a commit
to VOICEVOX/ort
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
extern "C"ofBoundOperator's methods withextern_system_fn!.Fixes #64 that recurred.
I don't know x86 Windows build works, but at least it compiles from now.