Skip to content

feature: pyenv install latest #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Conversation

kirankotari
Copy link
Member

Usage and behavior is the same as in the original version of pyenv-latest (refers to this)

Prefix auto-resolution to the latest version also turned on for such commands: install, uninstall, global, local

So, from now user can just execute the following commands without having to search for the latest patch (and even minor) version

pyenv install 3.10
pyenv global 3.10

Closes #407, closes #372

note: issues above are outdated, pyenv-latest behavior has been changed and my PR fully (i hope so) supports it

@kirankotari kirankotari added this to the pyenv-win 3.8.0 milestone Mar 20, 2023
@kirankotari kirankotari enabled auto-merge April 7, 2023 18:38
@kirankotari kirankotari requested a review from Darsstar April 19, 2023 19:27
@bb010g
Copy link

bb010g commented Apr 28, 2023

Is there a recommended way to upgrade all floating, latest installations? An invocation like pyenv install -s -r 3 3.11 3.10 && pyenv global 3 3.11 3.10 is close, but specific floating versions have to be listed out.

@uhx
Copy link
Contributor

uhx commented May 9, 2023

Is there a recommended way to upgrade all floating, latest installations? An invocation like pyenv install -s -r 3 3.11 3.10 && pyenv global 3 3.11 3.10 is close, but specific floating versions have to be listed out.

There is no way to do that either here or in pyenv/pyenv

@otterrisk
Copy link

Closes #407, closes #372

Would also close #505, reviews very much appreciated 👍

@uhx
Copy link
Contributor

uhx commented Jul 21, 2023

Closes #407, closes #372

Would also close #505, reviews very much appreciated 👍

Sadly, no one of the maintainers seems to have time. The changes are quite complex and require a lot of attention

I still want to merge these features, so if anyone wants to make a review, I can make a fix in a few days

@bersbersbers
Copy link

I'd love to see this go forward! It's close to impossible to use pyenv on CI, having to specify patch versions as well.

@stansotn
Copy link

The absence of this feature is blocking our org from using pyenv in CI on Windows.

Darsstar
Darsstar previously approved these changes Dec 27, 2023
@Darsstar
Copy link
Collaborator

Sorry, I should have made time for this sooner.

Darsstar
Darsstar previously approved these changes Dec 27, 2023
uhx and others added 8 commits December 27, 2023 14:52
Usage and behavior is the same as in the original version of pyenv-latest.

Prefix auto-resolution to the latest version also turned on for such commands: install, global, local

So, from now user can just execute the following commands without the need of searching for latest patch version (or even minor)

pyenv install 3.10
pyenv global 3.10
From now it may pin python version without patch.
Also fixed pyenv-install without arguments: it should pick the local/global version and then install it.
@stansotn
Copy link

stansotn commented Jan 4, 2024

@bb010g Could you please submit your review.

@nicocvn
Copy link

nicocvn commented Mar 5, 2024

@kirankotari do you know if there is any hope this PR will get merged at some point? This is almost 1 year old, and without these changes pyenv-win is not usable in CI setups.

Would it be possible to find someone else among the contributors to speed up the review and approval process?

@bb010g
Copy link

bb010g commented Mar 6, 2024

@kirankotari Could a member of the @pyenv-win org grant access to Reviewable for this organization? (See https://docs.reviewable.io/registration.html.) Just drafted a review on there with a few comments before realizing I couldn't publish it. (At least for me, GitHub's application settings page for Reviewable is https://github.com/settings/connections/applications/7da38b6fb966259af6d5; you might be able to request/grant access from there. Alternatively, https://github.com/orgs/pyenv-win/policies/applications/128315 should work.)

@molinav
Copy link

molinav commented Mar 6, 2024

@nicocvn If your major need is related to GitHub workflows, I wrote a simple composite action to install pyenv-win with a given Python version that also allows to provide "latest" or a Python version without the patch number and then it will pick the newest:
https://github.com/pylegacy/actions

The example below would install e.g. the latest available Python 3.11:

name: Set Python
uses: pylegacy/actions/setup-pyenv-win@v2
with:
    architecture: "x64"
    python-version: "3.11"

Internally, the action is using pyenv install --list to find the best version with a regex pattern match before installing it.

@kirankotari kirankotari requested a review from a team as a code owner April 4, 2024 12:01
@kirankotari kirankotari disabled auto-merge April 4, 2024 12:03
@Darsstar Darsstar enabled auto-merge April 4, 2024 12:11
@kirankotari kirankotari disabled auto-merge April 4, 2024 12:43
@kirankotari kirankotari merged commit 64efe94 into master Apr 4, 2024
@kirankotari kirankotari deleted the feature/pyenv-install-latest branch April 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyenv install x.y:latest feature: Support pyenv install x.y:latest, like pyenv does
9 participants