Skip to content

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle added the third-party-tests Add this label on a PR to trigger 3rd party tests label Dec 30, 2024
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 30, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 30, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56743c9
Status: ✅  Deploy successful!
Preview URL: https://c5a354f4.pydantic-docs.pages.dev
Branch Preview URL: https://test-odmantic.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #11197 will not alter performance

Comparing test-odmantic (56743c9) with main (4332d8f)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle sydney-runkle mentioned this pull request Dec 30, 2024
16 tasks
@sydney-runkle sydney-runkle requested a review from Viicos December 30, 2024 19:33
@sydney-runkle
Copy link
Contributor Author

sydney-runkle commented Dec 30, 2024

cc @art049, we're adding third party tests to better anticipate changes that might be breaking for folks. Looks like this indicates that you'll see some deprecations when moving to v2.11 in regards to your model_fields access on instances.

See #11169 for more details!

Update: I've opened a PR against odmantic to fix this: art049/odmantic#510

@Viicos Viicos changed the title CI: Add third party odmantic tests Add ODMantic third-party tests Dec 31, 2024
@Viicos Viicos enabled auto-merge (squash) December 31, 2024 10:21
@Viicos Viicos merged commit 7afefe6 into main Dec 31, 2024
83 checks passed
@Viicos Viicos deleted the test-odmantic branch December 31, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants