Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Dec 30, 2024

Change Summary

Part of #11160.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 30, 2024
@Viicos Viicos mentioned this pull request Dec 30, 2024
16 tasks
@Viicos Viicos added the third-party-tests Add this label on a PR to trigger 3rd party tests label Dec 30, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 30, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: edc8fd4
Status: ✅  Deploy successful!
Preview URL: https://d8a7ef95.pydantic-docs.pages.dev
Branch Preview URL: https://pandera-ci.pydantic-docs.pages.dev

View logs

@Viicos Viicos closed this Dec 30, 2024
@Viicos Viicos reopened this Dec 30, 2024
Copy link

codspeed-hq bot commented Dec 30, 2024

CodSpeed Performance Report

Merging #11193 will degrade performances by 5.78%

Comparing pandera-ci (edc8fd4) with main (cfd4c9f)

Summary

❌ 1 (👁 1) regressions
✅ 45 untouched benchmarks

Benchmarks breakdown

Benchmark main pandera-ci Change
👁 test_simple_model_validation[model_validate] 40.1 µs 42.6 µs -5.78%

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos enabled auto-merge (squash) December 30, 2024 16:38
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some questions about our general structure for this test file.

strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No 3.12?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like they are lagging behind Python versions..

Comment on lines +5 to +10
# Instructions:
# - The CI should be as close as possible to the original project's workflows.
# - Use the checkout action to clone Pydantic with a custom path (e.g. `path: pydantic-latest`).
# - Make sure Pydantic is installed in editable mode (e.g. `uv pip install -e ./pydantic-latest`)
# so that the path appears in the `pip list` output (and so we can be assured Pydantic was properly
# installed from the provided path).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to add these here. There's so much redundancy across jobs, maybe we could consolidate with shared logic for installing pydantic and settings things up...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is each library depends on different tools: pip, uv, pdm, etc so having things consolidated is quite hard

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Viicos Viicos merged commit 4332d8f into main Dec 30, 2024
79 checks passed
@Viicos Viicos deleted the pandera-ci branch December 30, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants