Skip to content

Add openapi-python-client to third-party tests #11171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

Add openapi-python-client to third-party tests #11171

merged 1 commit into from
Dec 27, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Dec 22, 2024

Change Summary

Part of #11160.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 22, 2024
@Viicos Viicos added the third-party-tests Add this label on a PR to trigger 3rd party tests label Dec 22, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 22, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa5e319
Status: ✅  Deploy successful!
Preview URL: https://3006ab01.pydantic-docs.pages.dev
Branch Preview URL: https://openapi-python-client-3rd-pa.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the openapi-python-client-3rd-party branch 2 times, most recently from affc864 to cf2b8f2 Compare December 22, 2024 19:22
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #11171 will not alter performance

Comparing openapi-python-client-3rd-party (aa5e319) with main (aea47de)

Summary

✅ 46 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos force-pushed the openapi-python-client-3rd-party branch 2 times, most recently from 088b852 to 2b3e754 Compare December 22, 2024 19:27
Viicos
Viicos commented Dec 22, 2024
View reviewed changes
.github/workflows/third-party.yml
Comment on lines +132 to +134
with:
repository: Viicos/openapi-python-client
ref: 'model-rebuild'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: can change once openapi-generators/openapi-python-client#1176 is merged.

@Viicos Viicos force-pushed the openapi-python-client-3rd-party branch from 2b3e754 to aa5e319 Compare December 22, 2024 19:31
@Viicos Viicos mentioned this pull request Dec 22, 2024
Open
16 tasks
sydney-runkle
sydney-runkle approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing, so I'm happy here!

@sydney-runkle
Copy link
Contributor

Also nice touch, I missed the issue creation step in the other PR, but good call there 👍

@sydney-runkle sydney-runkle removed the relnotes-fix Used for bugfixes. label Dec 27, 2024
@sydney-runkle sydney-runkle merged commit fac2bfd into main Dec 27, 2024
68 checks passed
@sydney-runkle sydney-runkle deleted the openapi-python-client-3rd-party branch December 27, 2024 16:01
@sydney-runkle sydney-runkle mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @sydney-runkle