Move FastAPI tests to third-party workflow #11164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
bfc2efb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccab206e.pydantic-docs.pages.dev |
| Branch Preview URL: | https://adapt-fastapi-ci.pydantic-docs.pages.dev |
Viicos
commented
Dec 20, 2024
Comment on lines
-18
to
-23
| # This may be necessary if we make low-consequence changes to pydantic, such as minor changes the details of a JSON | ||
| # schema or the contents of a ValidationError | ||
| # | ||
| # To skip a specific test, add '--deselect path/to/test.py::test_name' to the end of this command | ||
| # | ||
| # To update the list of deselected tests, remove all deselections, run the tests, and re-add any remaining failures |
There was a problem hiding this comment.
Note that we loose the ability to skip failing tests. But the pytest command that we run in the third-party workflow can still be adapted to deselect tests.
And more generally, it might be that we get failing third-party tests if the main branch of the projects we test is broken. If this happens too often, we can checkout a specific revision instead (but we'll have to remind ourselves to update the revision regularly).
CodSpeed Performance ReportMerging #11164 will improve performances by 5.89%Comparing Summary
Benchmarks breakdown
|
83cd93f to
bfc2efb
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Part of #11160
Related issue number
Checklist