Improve discriminated union error message for invalid union variants #11161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
d40b72f to
4a83068
Compare
Deploying pydantic-docs with
|
| Latest commit: |
bca5c56
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83047679.pydantic-docs.pages.dev |
| Branch Preview URL: | https://discriminated-union-errors.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11161 will not alter performanceComparing Summary
|
Remove duplicated test and improve `test_plain_function_schema_is_invalid` to make use of a real model definition.
4a83068 to
bca5c56
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Dec 20, 2024
As I mentioned, a refactor would get rid of the two places, so probably best to go this way in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated test and improve
test_plain_function_schema_is_invalidto make use of a real model definition.
Change Summary
Closes #11158.
Note that more cleanups could be applied to the discriminator inference logic. I was able to remove one useless condition check, but we still raise the same error in two different places and with a bit of refactoring we can surely simplify it further.
Related issue number
Checklist