Infer final fields with a default value as class variables in the mypy plugin #11121
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
7e7f616
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21c3e866.pydantic-docs.pages.dev |
| Branch Preview URL: | https://final-mypy-plugin.pydantic-docs.pages.dev |
This was referenced Dec 15, 2024
CodSpeed Performance ReportMerging #11121 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
| @@ -761,6 +761,10 @@ def collect_field_or_class_var_from_stmt( # noqa C901 | |||
| ) | |||
| node.type = AnyType(TypeOfAny.from_error) | |||
|
|
|||
| if node.is_final and has_default: | |||
| # TODO this path should be removed (see https://github.com/pydantic/pydantic/issues/11119) | |||
There was a problem hiding this comment.
Can you add a note about when, or what is blocking this?
There was a problem hiding this comment.
The linked issue should be enough?
sydney-runkle
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10474, closes #10848.
Change Summary
Related issue number
Checklist