Override __subclasscheck__ on ModelMetaclass to avoid memory leak and performance issues
#11116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and performance issues We avoid relying on `ABCMeta.__subclasscheck__` unless we're pretty sure. Note that this was wrongly addressed as `__instancecheck__` was implemented instead of `__subclasscheck__`. However, it is not clear if implementing `__instancecheck__` fixed existing issues as well, so it is left as is. Also changed the checked attribute to `__pydantic_decorators__`, as this is one of the first attributes being set on the class, and it might be that we change the way `__pydantic_validator__` is set in the future (e.g. when `defer_build` is set, and if we don't implement mock validators anymore).
Deploying pydantic-docs with
|
| Latest commit: |
1922dfe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41a7f040.pydantic-docs.pages.dev |
| Branch Preview URL: | https://subclasscheck.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11116 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
sydney-runkle
approved these changes
Dec 16, 2024
|
What kind of test are you looking for? We already have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid relying on
ABCMeta.__subclasscheck__unless we're pretty sure. Note that this was wrongly addressed as__instancecheck__was implemented instead of__subclasscheck__. However, it is not clear if implementing__instancecheck__fixed existing issues as well, so it is left as is.Also changed the checked attribute to
__pydantic_decorators__, as this is one of the first attributes being set on the class, and it might be that we change the way__pydantic_validator__is set in the future (e.g. whendefer_buildis set, and if we don't implement mock validators anymore).Fixes #11100.
Change Summary
Related issue number
Checklist