Skip to content

Add cadwyn to the third-party test suite #11861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 19, 2025
Merged

Add cadwyn to the third-party test suite #11861

merged 8 commits into from
May 19, 2025
+44 −1

Conversation

zmievsa
Copy link
Contributor

@zmievsa zmievsa commented May 10, 2025 •
edited by pydantic-hooky bot
Loading

Fix #11654

Change Summary

Add cadwyn to the third-party test suite in a very similar manner to FastAPI

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @DouweM

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2025 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11861 will not alter performance

Comparing zmievsa:11654-add-cadwyn-to-third-party-test-suite (1803513) with main (aadf00e)

Summary

✅ 46 untouched benchmarks

@zmievsa zmievsa marked this pull request as ready for review May 11, 2025 08:10
@zmievsa
Copy link
Contributor Author

zmievsa commented May 11, 2025

Please review

@DouweM
Copy link
Contributor

DouweM commented May 12, 2025

@zmievsa Thanks, looks good!

@Viicos Can you please give this a final look?

@Viicos Viicos changed the title #11654 Add cadwyn to the third-party test suite Add cadwyn to the third-party test suite May 13, 2025
@Viicos Viicos added third-party-tests Add this label on a PR to trigger 3rd party tests relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels May 13, 2025
@Viicos Viicos closed this May 13, 2025
@Viicos Viicos reopened this May 13, 2025
Viicos
Viicos requested changes May 13, 2025
View reviewed changes
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zmievsa, a couple comments

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels May 13, 2025
@pydantic-hooky pydantic-hooky bot assigned zmievsa and unassigned DouweM May 13, 2025
@zmievsa zmievsa requested a review from Viicos May 17, 2025 19:09
Viicos
Viicos reviewed May 19, 2025
View reviewed changes
@Viicos Viicos enabled auto-merge (squash) May 19, 2025 10:25
@Viicos Viicos removed the awaiting author revision awaiting changes from the PR author label May 19, 2025
@Viicos Viicos merged commit 53f460c into pydantic:main May 19, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DouweM DouweM DouweM approved these changes

@Viicos Viicos Viicos approved these changes

Assignees

@zmievsa zmievsa

Labels
relnotes-ignore Omit this PR from the release notes. third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Cadwyn test suite to pydantic
3 participants
@zmievsa @DouweM @Viicos