-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Do not provide field_name
in validator core schemas
#11761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Change SummaryRemoved the deprecated field_name argument from the validation function schemas to enhance compatibility with the latest pydantic-core updates.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
CodSpeed Performance ReportMerging #11761 will not alter performanceComparing Summary
|
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
f880c7e
to
a8825c0
Compare
@Viicos Pleas review! |
field_name
in validator core schemas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test reproducing the original issue in #11737. I also released 2.34.1 yesterday so you can use it; it should fix the free threaded CI. Otherwise looks good!
a8825c0
to
c6be7b8
Compare
@Viicos Bumped to 2.34.1 and added the test! |
4096dbb
to
92109b3
Compare
…on reused type alias
92109b3
to
b25047c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'm glad this isn't stored on the schema anymore!
https://build.opensuse.org/request/show/1287850 by user dgarcia + anag_factory To stage with the python-pydantic-core 2.35.1 update in sr#1287849 - Add patch bump-pydantic-core-2.35.1.patch to support latest pydantic-core, gh#pydantic/pydantic#11963 - Add patch field-name-validator-core-schemas.patch to remove deprecation warning, gh#pydantic/pydantic#11761 - Update to 2.11.7 * Copy FieldInfo instance if necessary during FieldInfo build by @Viicos in #11980 2.11.6 * Rebuild dataclass fields before schema generation by @Viicos in #11949 * Always store the original field assignment on FieldInfo by @Viicos in #11946 2.11.5 * Check if FieldInfo is complete after applying type variable map by @Viicos in #11855 * Do not delete mock validator/serializer in model_rebuild() by @Viicos in #11890 * Do not duplicate metadata on model rebuild by @Viicos in #11902
Change Summary
Companion to pydantic/pydantic-core#1692 to stop using deprecated
field_name
argument on validation function schemas.Fixes #11737.
Related issue number
Checklist