Remove generics cache workaround #11755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in parameterized classes being different type objects, although they represent the same type. A new refactor (#11388) was introduced since then and fixes the root issue.
Viicos
commented
Apr 15, 2025
tests/test_forward_ref.py
Outdated
There was a problem hiding this comment.
Mostly reverting test changes in #10704.
CodSpeed Performance ReportMerging #11755 will not alter performanceComparing Summary
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
Deploying pydantic-docs with
|
| Latest commit: |
95b79f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5fbc6163.pydantic-docs.pages.dev |
| Branch Preview URL: | https://remove-caching-generics.pydantic-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in parameterized classes being different type objects, although they represent the same type.
A new refactor (#11388) was introduced since then and fixes the root issue.
Fixes #11747.
Checklist