Skip to content

Fix crash when expanding root type in the mypy plugin #11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Fix crash when expanding root type in the mypy plugin #11735

merged 1 commit into from
Apr 17, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Apr 11, 2025

Change Summary

Fixes #11727.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Apr 11, 2025
@Viicos Viicos added the backport-2.11 Needs backport to 2.11 label Apr 11, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 11, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16d112c
Status: ✅  Deploy successful!
Preview URL: https://852d7a4a.pydantic-docs.pages.dev
Branch Preview URL: https://root-type-fw-ref.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the root-type-fw-ref branch from ace3d84 to 16d112c Compare April 11, 2025 08:51
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11735 will not alter performance

Comparing root-type-fw-ref (16d112c) with main (2e7cddb)

Summary

✅ 46 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py 345
Project Total  

This report was generated by python-coverage-comment-action

dmontagu
dmontagu approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@dmontagu dmontagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea what's going on but this seems safe enough

@Viicos
Copy link
Member Author

Viicos commented Apr 17, 2025

no idea what's going on but this seems safe enough

Not entirely sure either, this happens with forward references but my mypy knowledge is too limited to understand how they do it for stdlib dataclasses..

@Viicos Viicos merged commit c477e46 into main Apr 17, 2025
62 checks passed
@Viicos Viicos deleted the root-type-fw-ref branch April 17, 2025 16:31
Viicos added a commit that referenced this pull request Apr 17, 2025
@Viicos
Fix crash when expanding root type in the mypy plugin
f5d1c87 
Backport of: #11735
@tjb9dc tjb9dc mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees
No one assigned
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in mypy plugin with type alias, root model and forward reference
2 participants
@Viicos @dmontagu