Skip to content

Properly fetch plain serializer function when serializing default value in JSON Schema #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Properly fetch plain serializer function when serializing default value in JSON Schema #11721

merged 2 commits into from
Apr 9, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Apr 8, 2025

Change Summary

Fixes #11446.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Apr 8, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 8, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 017d78e
Status: ✅  Deploy successful!
Preview URL: https://de545c1e.pydantic-docs.pages.dev
Branch Preview URL: https://js-default-ser-nested.pydantic-docs.pages.dev

View logs

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11721 will not alter performance

Comparing js-default-ser-nested (017d78e) with main (8f6508a)

Summary

✅ 46 untouched benchmarks

davidhewitt
davidhewitt approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

@Viicos Viicos merged commit 2e7cddb into main Apr 9, 2025
62 checks passed
@Viicos Viicos deleted the js-default-ser-nested branch April 9, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serializer is not applied to json schema default value
2 participants
@Viicos @davidhewitt