Skip to content

Do not expand root type in the mypy plugin for variables #11676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Do not expand root type in the mypy plugin for variables #11676

merged 1 commit into from
Apr 2, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Apr 2, 2025 •
edited
Loading

Change Summary

Fixes #11675, fixes #11657.

Regression in #11212.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos added relnotes-fix Used for bugfixes. backport-2.11 Needs backport to 2.11 labels Apr 2, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 2, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91ea280
Status: ✅  Deploy successful!
Preview URL: https://630e571a.pydantic-docs.pages.dev
Branch Preview URL: https://mypy-root-var.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11676 will not alter performance

Comparing mypy-root-var (91ea280) with main (6c38dc9)

Summary

✅ 46 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos mentioned this pull request Apr 2, 2025
Closed
1 task
@Viicos Viicos merged commit cbf4202 into main Apr 2, 2025
62 checks passed
@Viicos Viicos deleted the mypy-root-var branch April 2, 2025 15:01
Viicos added a commit that referenced this pull request Apr 2, 2025
@Viicos
Do not expand root type in the mypy plugin for variables
f2cc8c3 
Backport of: #11676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Root models are sometimes inferred as unions by mypy when using the mypy plugin Root model classes are considered as an union type by mypy
2 participants
@Viicos @davidhewitt