Add experimental support for free threading #11516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar logic to the recursion state
Nothing we can really do on these ones, the `generate_schema_calls` fixture monkeypatches code and this will happen across threads.
Deploying pydantic-docs with
|
| Latest commit: |
03d03fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fdfb6bc1.pydantic-docs.pages.dev |
| Branch Preview URL: | https://freethreaded.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11516 will not alter performanceComparing Summary
|
Viicos
commented
Mar 3, 2025
| @@ -2149,6 +2150,7 @@ class Yard(BaseModel): | |||
| assert str(yard_dict['pet']['type']) == 'dog' | |||
|
|
|||
|
|
|||
| @pytest.mark.thread_unsafe(reason='Passes on multithreaded. This needs to be investigated further.') | |||
There was a problem hiding this comment.
While all the other tests marked as thread unsafe made sense, I have no idea why this one passes. Core schemas are identical, and verified it isn't a late lambda binding issue. Might be something in core?
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
davidhewitt
reviewed
Mar 5, 2025
| @@ -94,7 +94,7 @@ def __delitem__(self, key: KT) -> None: | |||
| # and discover later on that we need to re-add all this infrastructure... | |||
| # _GENERIC_TYPES_CACHE = DeepChainMap(GenericTypesCache(), LimitedDict()) | |||
|
|
|||
| _GENERIC_TYPES_CACHE = GenericTypesCache() | |||
| _GENERIC_TYPES_CACHE: ContextVar[GenericTypesCache | None] = ContextVar('_GENERIC_TYPES_CACHE', default=None) | |||
There was a problem hiding this comment.
The idea here is to make a separate cache for each thread?
There was a problem hiding this comment.
Yes exactly, identical to the recursion cache:
pydantic/pydantic/_internal/_generics.py
Line 396 in bff7477
|
Makes sense to get this into the 2nd beta next week 👍 |
davidhewitt
approved these changes
Mar 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #10483.
Related issue number
Checklist