Skip to content

Conversation

sydney-runkle
Copy link
Contributor

If validate_by_alias is manually set to False and validate_by_name is unset, we set validate_by_name to True.

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Feb 27, 2025
Copy link

cloudflare-workers-and-pages bot commented Feb 27, 2025

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a86ca6
Status: ✅  Deploy successful!
Preview URL: https://14e628c2.pydantic-docs.pages.dev
Branch Preview URL: https://by-name-dynamic-default.pydantic-docs.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #11503 will not alter performance

Comparing by-name-dynamic-default (3a86ca6) with main (f9f26e8)

Summary

✅ 46 untouched benchmarks

@sydney-runkle sydney-runkle force-pushed the by-name-dynamic-default branch from c8c960e to 70cceff Compare February 27, 2025 15:11
@sydney-runkle sydney-runkle requested a review from Viicos February 27, 2025 15:46
@Viicos Viicos changed the title Dynamic patch for validate_by_name when validate_by_alias=False Implicitly set validate_by_name to True when validate_by_alias is False Feb 27, 2025
@sydney-runkle
Copy link
Contributor Author

Codspeed is just being flaky here, that regression is unrelated.

@sydney-runkle sydney-runkle enabled auto-merge (squash) February 27, 2025 16:06
@sydney-runkle sydney-runkle merged commit 789819d into main Feb 27, 2025
55 checks passed
@sydney-runkle sydney-runkle deleted the by-name-dynamic-default branch February 27, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants