Support strict specification on union member types #11481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working to override config
Deploying pydantic-docs with
|
| Latest commit: |
620e0b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://573a8393.pydantic-docs.pages.dev |
| Branch Preview URL: | https://fix-union-ser-strict.pydantic-docs.pages.dev |
sydney-runkle
commented
Feb 24, 2025
Comment on lines
+1723
to
+1727
| inner_schema = {**cls._inner_schema, 'strict': strict} | ||
| json_schema = core_schema.no_info_after_validator_function( | ||
| source, # construct the type | ||
| inner_schema, # pyright: ignore[reportArgumentType] | ||
| ) |
There was a problem hiding this comment.
This is kind of gross, but so is this whole custom core schema construct for secret types
CodSpeed Performance ReportMerging #11481 will not alter performanceComparing Summary
|
dmontagu
approved these changes
Feb 25, 2025
sydney-runkle
added a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with pydantic/pydantic-core#1638
Addresses the bug reported in #10571
In
pydantic, we already don't allow users to apply thestrictannotation to union types. This PR ensures that thestrictspecification on union members is respected (overrides config spec, if necessary).