Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Nov 20, 2024

Change Summary

Fixes #10892.

Also update some docstrings to explain better how frame fetching works.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 20, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 88c495f
Status: ✅  Deploy successful!
Preview URL: https://37879cd6.pydantic-docs.pages.dev
Branch Preview URL: https://10892.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #10893 will not alter performance

Comparing 10892 (88c495f) with main (a5d5c23)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos force-pushed the 10892 branch 2 times, most recently from 4d63e75 to 30f43fa Compare November 20, 2024 13:08
@Viicos Viicos marked this pull request as draft November 20, 2024 13:51
@Viicos Viicos marked this pull request as ready for review November 20, 2024 16:46
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the docstring reorganization + additions.

Just one follow up question about parent frame fetching :)

@sydney-runkle sydney-runkle added the awaiting author revision awaiting changes from the PR author label Nov 20, 2024
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! Let's get this into v2.10.1

@Viicos Viicos enabled auto-merge (squash) November 21, 2024 13:52
@Viicos Viicos merged commit 36642e6 into main Nov 21, 2024
51 checks passed
@Viicos Viicos deleted the 10892 branch November 21, 2024 13:55
sydney-runkle pushed a commit that referenced this pull request Nov 22, 2024
…#10893)

Move all the documentation into the class docstring, rewrite some small parts of it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting author revision awaiting changes from the PR author relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parent namespace fetched when using an explicitly parametrized TypeAdapter
2 participants