Revalidate parametrized generics if instance's origin is subclass of OG class #10666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
3b54ddb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b849e91.pydantic-docs.pages.dev |
| Branch Preview URL: | https://generic-origin-addition.pydantic-docs.pages.dev |
dmontagu
reviewed
Oct 21, 2024
dmontagu
reviewed
Oct 21, 2024
dmontagu
approved these changes
Oct 22, 2024
CodSpeed Performance ReportMerging #10666 will not alter performanceComparing Summary
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
jvansanten
added a commit
to AmpelProject/Ampel-interface
that referenced
this pull request
Nov 22, 2024
Obviated by pydantic/pydantic#10666, which does the Right Thing with instances of unparameterized generics.
jvansanten
added a commit
to AmpelProject/Ampel-interface
that referenced
this pull request
Nov 22, 2024
Obviated by pydantic/pydantic#10666, which does the Right Thing with instances of unparameterized generics.
jvansanten
added a commit
to AmpelProject/Ampel-interface
that referenced
this pull request
Nov 22, 2024
Obviated by pydantic/pydantic#10666, which does the Right Thing with instances of unparameterized generics.
jvansanten
added a commit
to AmpelProject/Ampel-interface
that referenced
this pull request
Nov 22, 2024
Obviated by pydantic/pydantic#10666, which does the Right Thing with instances of unparameterized generics.
jvansanten
added a commit
to AmpelProject/Ampel-interface
that referenced
this pull request
Nov 22, 2024
Obviated by pydantic/pydantic#10666, which does the Right Thing with instances of unparameterized generics.
jvansanten
added a commit
to AmpelProject/Ampel-interface
that referenced
this pull request
Nov 22, 2024
* chore(deps): update minor updates * chore: use annotations from pydantic for overrides IncEx is public as of pydantic 2.10 * fix: remove workarounds for generic validation Obviated by pydantic/pydantic#10666, which does the Right Thing with instances of unparameterized generics. * chore(deps): remove ruff from poetry env --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jakob van Santen <jvansanten@gmail.com>
1 task
Viicos
added a commit
that referenced
this pull request
Dec 27, 2024
This is no longer necessary since #10666 was introduced.
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires pydantic/pydantic-core#1489
Fixes #9414
Fixes #10359
Fixes #8071
See docs updates for a more thorough explanation of changes - basically, generic validation is in some cases less performant, but at the benefit of being much more intuitive.
Specifically, see the implementation details section here: https://generic-origin-addition.pydantic-docs.pages.dev/concepts/models/#generic-models