How hard would it be to (temporarily) support both imgui < 1.92 and imgui >= 1.92? Some upstream libs have now pinned imgui to < 1.92.

Or we can decide to pin imgui = ["imgui-bundle>=1.92, <1.93"]

How hard would it be to (temporarily) support both imgui < 1.92 and imgui >= 1.92? Some upstream libs have now pinned imgui to < 1.92.

Maintaining compatibility with both versions at the same time shouldn’t be too complicated — I’ll take a look.

How hard would it be to (temporarily) support both imgui < 1.92 and imgui >= 1.92? Some upstream libs have now pinned imgui to < 1.92.

Since some logic of ImguiWgpuBackend has changed, I think the simplest solution is to keep two versions of ImguiWgpuBackend and dynamically import the appropriate one based on the version of imgui_bundle.

What do you think? @almarklein @kushalkolar
Do you think it's necessary to maintain both versions like this?

That was fast, @panxinmiao you are awesome 🎉

How hard would it be to (temporarily) support both imgui < 1.92 and imgui >= 1.92? Some upstream libs have now pinned imgui to < 1.92.

Since some logic of ImguiWgpuBackend has changed, I think the simplest solution is to keep two versions of ImguiWgpuBackend and dynamically import the appropriate one based on the version of imgui_bundle.

What do you think? @almarklein @kushalkolar Do you think it's necessary to maintain both versions like this?

It seems like imgui-bundle v1.92 has wheels for python 3.11-313 on all major platforms, the same as imgui-bundle v1.6.4.

BTW there is pypodide support too now which will be great for the future 😄

@kushalkolar I've updated the imgui_cmap_picker.py example.

How hard would it be to (temporarily) support both imgui < 1.92 and imgui >= 1.92? Some upstream libs have now pinned imgui to < 1.92.

Since some logic of ImguiWgpuBackend has changed, I think the simplest solution is to keep two versions of ImguiWgpuBackend and dynamically import the appropriate one based on the version of imgui_bundle.

What do you think? @almarklein @kushalkolar Do you think it's necessary to maintain both versions like this?

If the differences are this significant, I think we should just bit the bullet and require the latest imgui version. Can you update pyproject to set imgui = ["imgui-bundle>=1.92, <1.93"]?

On second thought, let's assume the following few versions are compatible, and use imgui = ["imgui-bundle>=1.92, <2"]

Thanks Pan!

is this worth a new release?