Add vflip for textures #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Korijn
approved these changes
Mar 11, 2024
|
I would suggest to just drop 3.8 :) |
|
that is also an option. However 3.8 is end of life in a few months and the typing syntax does change with seemingly every single release since. Alternatively if we really want typing that works across versions using the I am okay with leaving it as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4
This PR ads the vertical flip option for texture inputs. By default images aren't upside down anymore.
Additionally this PR includes a minor refactor to leverage the numpy and PIL runtime dependencies added in #25. This makes it a step easier to use custom images as textures.
Fixes greyscale textures now behaving like the website reference (they are red).