Skip to content

Colormap clamp #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Colormap clamp #987

merged 1 commit into from
Feb 18, 2025

Conversation

almarklein
Copy link
Member

Closes #979

  • Clamps the values after the gamma correction step. In the image/volume shader the values to sample the colormap are always between zero and one, because clim etc.
  • Turns the default colormaps into TextureMap objects with wrap="clamp".

@almarklein almarklein requested a review from Korijn as a code owner February 18, 2025 11:10
@almarklein almarklein mentioned this pull request Feb 18, 2025
Closed
@almarklein almarklein enabled auto-merge (squash) February 18, 2025 11:11
Korijn
Korijn previously approved these changes Feb 18, 2025
View reviewed changes
@almarklein
Copy link
Member Author

I accidentally added my intended changes to a previous branch. I cleaned up and force-pushed.

@almarklein almarklein merged commit e4f8f77 into main Feb 18, 2025
14 checks passed
@almarklein almarklein deleted the colormap-clamp branch February 18, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korijn Korijn Korijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#957 causes issues with colormap clamping on lavapipe on github actions
2 participants
@almarklein @Korijn