Add View class #954
Draft
Add View class #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #492 and #495
This adds a new
Viewclass that replaces theViewportclass andDisplay/showfunctionality. Its a bit like a combination of both. The idea is that it automates all the plumbing to connect everything together for most use-cases.Later we will make the renderer a bit more low-level by removing events; the viewport will take that role instead. See #492. One can also easily create subplots with this. For now this will be rather inefficient, but it will become efficient again when we refactor the renderer to have a predefined size and not wrapping a canvas anymore (#492).
The idea is that with this, ppl can already move to the new api.