Skip to content

Cache camera matrices #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2025
Merged

Cache camera matrices #945

merged 4 commits into from
Jan 20, 2025

Conversation

Korijn
Copy link
Collaborator

@Korijn Korijn commented Jan 19, 2025 •
edited
Loading

This PR leverages the @cached attribute on the Camera classes for all computed attributes.

As you can see in the examples it simplifies user code and internals a lot!

@Korijn Korijn mentioned this pull request Jan 19, 2025
Closed
@Korijn Korijn requested a review from almarklein January 19, 2025 20:10
almarklein
almarklein approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@almarklein almarklein merged commit a8d852c into main Jan 20, 2025
14 checks passed
@almarklein almarklein deleted the camera-caching branch January 20, 2025 11:26
@kushalkolar kushalkolar mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almarklein almarklein almarklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Korijn @almarklein