fix Controller.cameras property, add a very basic test
#791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm guessing failure is related to the release of numpy v2 a few hours ago: https://github.com/pygfx/pygfx/actions/runs/9538926238/job/26288692137?pr=791#step:7:188 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/runpy.py:288: in run_path
return _run_module_code(code, init_globals, run_name,
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/runpy.py:97: in _run_module_code
_run_code(code, mod_globals, init_globals,
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/runpy.py:87: in _run_code
exec(code, run_globals)
examples/feature_demo/multi_slice2.py:21: in <module>
from skimage.measure import marching_cubes
/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/skimage/__init__.py:122: in <module>
from ._shared import geometry
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> ???
E ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObjectskimage is probably compiled against older numpy than v2 |
almarklein
approved these changes
Jun 17, 2024
|
Thinking of the best way to fix the numpy issue 🤔 maybe an extra optional dep-group, so in our CI we can write |
|
Fixing CI in #793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #790