Skip to content

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Apr 6, 2024

This was found in #704

It seems that write_pick was previously used a sentinel to detect the type of pass that was getting used.

It is currently defined as true when:

  • BasePass
  • OpaquePass
  • FullOpaquePass
  • SimpleSinglePass
  • FrontmostTransparencyPass

This was found in pygfx#704

It seems that write_pick was previously used a sentinel to detect the
type of pass that was getting used.

It is currently defined as true when:

* BasePass
* OpaquePass
* FullOpaquePass
* SimpleSinglePass
* FrontmostTransparencyPass
@hmaarrfk hmaarrfk requested a review from Korijn as a code owner April 6, 2024 13:03
@almarklein
Copy link
Member

Nice find btw. I think this is from before we had FrontmostTransparencyPass.

@Korijn Korijn merged commit e99718f into pygfx:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants