-
-
Notifications
You must be signed in to change notification settings - Fork 55
Allow picking of background objects #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So maybe I'm hacking too much and feel free to reject this patch, but I'm overlaying one scene onto the main scene to create some kind of picture in picture preview. It would be really useful to interact with the background of the scene since it indicates that the user has clicked on the picture in picture (but maybe not on an object). I haven't really gone through the codepath to make picking background textures meaningful but this is already more than enough for me. Otherwise, the pick just goes to the "object behind my picture in picture". Thanks for considering
4dfa79a
to
d2fa038
Compare
ok so for the skybox, you basically sample with a direction vector, which isn't super intuitive and I'm not sure how you perfer to return this. The basics are in here. I need to review with a clear head to get something "right". Some questions I still need to answer for myself:
|
Oh, I now realize I assumed that the I propose to keep it simple:
|
Are these mutually exclusive options? Sorry the choice of words makes it seem like they could be sequential. As it stand "right now" (i might force push to cleanup the commit history), the normalized direction vector is being sent. After sleeping on it, it makes sense to me for a direction vector to get sent because in a "skybox" the most important thing might be "the direction where the user clicked". The "6 sided cube trick" to me feels like a neat graphics trick, but I wonder if it helps or hinders the downstream application from being able to use the information effectively. For example, I could see an application placing markers:
away as the user clicks on the skybox. It seems that the picking info is super material specific, so I'm not too worried about that. If:
|
No I meant these as a package of choices to keep things simple. In other words, I said: let's forget about the skybox and always return a vector that can be used to see where on the screen the user clicked. Now that I think about it, the position where the user clicked should (eventually) be part of the |
I'm down, i just want it to "respond" to "mouse move". Right now, moving the mouse over the Background just "ignores it" |
Keeping it so simple it seems my top level comment is still appropriate. I added a comment pointing to this discussion. Not sure if you find that appropriate. Thanks for your time again! |
So maybe I'm hacking too much and feel free to reject this patch, but I'm overlaying one scene onto the main scene to create some kind of picture in picture preview.
It would be really useful to interact with the background of the scene since it indicates that the user has clicked on the picture in picture (but maybe not on an object).
I haven't really gone through the codepath to make picking background textures meaningful but this is already more than enough for me.
Otherwise, the pick just goes to the "object behind my picture in picture".
Thanks for considering