Make pixel_ratio follow canvas if it changes #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
approved these changes
Mar 21, 2024
Yup, we set it to 2 by default few weeks ago: fastplotlib/fastplotlib#412 Looks like we can remove it now and it will auto track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the pixel ratio logic again (see e.g. #638).
renderer.pixel_ratiois set to None, this will now follow the canvas' ratio, e.g. as it moves to a different screen, instead of staying fixed to whatever it was at the start.(0, 0).@kushalkolar have you seen that bug before? Perhaps you just set an explicit pixel_ratio to prevent it?
Implementation notes
self._pixel_ratiois not used outside of the property anymore.Noneto mean "auto mode".renderer.pixel_ratiomay change in the background, but it still always produces a value (so this pr does not undo Renderer.pixel_ratio always has a value #638).