Buffer and texture dtype validation #581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #579, and some general improvements, ref #19.
This fixes that 64-bit data could be passed to a buffer without pygfx complaining about it, resulting in a broken visualization.
Geometry(...)
is simply passed to the buffer constructor, so any checks happen in one place.Buffer
andTexture
constructor, instead of lazily. Fail early.Buffer.format
is nowNone
for e.g. uniform buffers (instead of raising an error).