Skip to content

Controllers save and load state #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2022
Merged

Controllers save and load state #297

merged 2 commits into from
Apr 19, 2022

Conversation

Korijn
Copy link
Collaborator

@Korijn Korijn commented Apr 18, 2022 •
edited
Loading

Closes #148

  • Adds Controller.save_state() and Controller.load_state(state=None) to all controller implementations
  • Controllers create an initial snapshot upon creation
  • Extends orbit and panzoom controller examples to demonstrate new features

orbit_saveload

panzoom_saveload

@Korijn Korijn mentioned this pull request Apr 18, 2022
Merged
@almarklein
Copy link
Member

LGTM 🚀

@Korijn Korijn merged commit 05436b9 into main Apr 19, 2022
@Korijn Korijn deleted the controller-save-load-state branch April 19, 2022 13:18
@Korijn Korijn mentioned this pull request Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve API of Controls (Orbit) to better support saving and restoring state
2 participants
@Korijn @almarklein