Add show util #229
Merged
Add show util #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Korijn
commented
Dec 24, 2021
Korijn
commented
Dec 24, 2021
Korijn
commented
Dec 24, 2021
almarklein
reviewed
Dec 24, 2021
d3b8275 to
5d80b9d
Compare
5d80b9d to
3527b78
Compare
|
I think this is ready now! |
This was referenced Dec 25, 2021
Closed
Closed
Korijn
commented
Dec 25, 2021
|
There were quite a lot of gotchas here, but it's working nicely now. I guess it only falls apart when the near/far planes are too small for the scene you're showing. That can be addressed in #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Closes #194
The idea is that you can visualize any world object immediately.
New API:
Geometry.bounding_box()Geometry.bounding_sphere()gfx.trimesh_geometry(mesh)Matrix4.to_ndarray()gfx.linalg.utils.transform(vectors, matrix)gfx.linalg.utils.aabb_to_sphere(aabb)gfx.linalg.utils.transform_aabb(aabb, matrix)WorldObject.get_world_position()WorldObject.get_world_bounding_box()WorldObject.get_world_bounding_sphere()Camera.show_object(target)gfx.show(object)New examples:
examples\show_util.pyexamples\show_stl.pyexamples\show_scene.py