-
-
Notifications
You must be signed in to change notification settings - Fork 55
Add support for FXAA and DDAA #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Korijn
reviewed
Jun 30, 2025
@Korijn this is also ready, btw |
Korijn
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75
FXAAPass
andDDAAPass
effects.renderer.ppaa
property that can be set to 'default', 'none', 'fxaa', or 'ddaa'.renderer.effect_passes
.PYGFX_PPAA
to control what 'default' resolves to. The primary use-case is to turn it off for image tests.Line without aa, on a regular (no-hidpi) screen, with pixel ratio 1:
With pixel ratio 2 (the trick we use by default):
With ddaa and pixel ratio 1:

More comparisons: https://almarklein.github.io/ppaa-experiments/viewer.html#image=lines.png&algs=ori,ssaax8,fxaa3,ddaa2
DDAA is bases on an idea I had in the early days of Visvis. I revived the idea and worked on it outside of "Pygfx hours". A small improvement in the perceived smoothness (without getting blurry) can be a big win, because it means we can turn the aa of objects off, which removes a whole range of artifacts, and maybe even reduce the ssaa (pixel_ratio).
Differences of DDAA w.r.t. FXAA:
For more info see https://github.com/almarklein/ppaa-experiments