Ready for review. I think I made a small change in the output pass (formerly flusher) causing the screenshot comparison tests to fail.

And CI is green!

Really cool. One of the effects I’ve wanted has been a « grayscale » effect.

It helps us generate assets that are 1/3 in size

@claydugo and I have been playing with workarounds (mostly doing the conversion on the CPU) for the grayscale filter.

Also some ideas for more effects:

Feel like some potential for interop with existing shadertoys. Especially those that read a texture (or two for depth?) and then draw to screen.

Feel like some potential for interop with existing shadertoys. Especially those that read a texture (or two for depth?) and then draw to screen.

Yeah, I guess the post-processing effects is like Shadertoy Light (TM) 😉.

They can actually have more textures as input (and also output); the base class makes no assumptions about the number of render and target textures. In terms of API, the EffectPass subclass should likely have properties that allow users to set a texture.

Hello,
Does renderer.snapshot() capture EffectPass ?
In the viewport I can see the fog pass,
but when I try to save several .snapshot as numpy arrays to make a video with imageio, the effect is not (yet?) rendered.
I know snapshot not exactly save the viewport, as it "samples from the internal texture, so the result may be different then what's shown on screen."

Anyway, thanks for your excellent library.

@Minigoer Good question! This is something that has crossed my mind, and which was considered in the design, but I have not addressed snapshot yet. Thanks for bringing it up. I'll add an entry in #1065.

The way that post-processing is implemented, is that it pingpongs between the texture that it renders to, and an alt texture. So snapshot cannot capture the original rendered image, but it can/should capture the image including post-processing. For what it's worth, I also considered the option where snapshot captured the render result without effects, but that made the code more complex and requires an additional render texture, so I decided against it.

Anyway, to fix this issue, the renderer should keep track of what the "final" texture is to take the screenshot from.

In the mean time, as a workaround, you can add a CopyPass if needed, so the final effect is in the original texture again 😃

@almarklein , it does the trick very well ! Thanks a lot !