Skip to content

Document pygame.math.Vector epsilon attribute #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2022
Merged

Document pygame.math.Vector epsilon attribute #3373

merged 1 commit into from
Aug 6, 2022

Conversation

oddbookworm
Copy link
Contributor

@oddbookworm oddbookworm commented Aug 4, 2022 •
edited
Loading

I documented Vector2.epsilon and Vector3.epsilon. Merging this PR would close #3368

ankith26
ankith26 approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fairly comprehensive and it clears up a lot of things about the secretive and mystic epsilon 😄
Very nice docs addition, thanks! 🎉 🥳

Starbuck5
Starbuck5 reviewed Aug 6, 2022
View reviewed changes
Starbuck5
Starbuck5 reviewed Aug 6, 2022
View reviewed changes
Starbuck5
Starbuck5 approved these changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 🎉

Only thing to resolve before merge is commit history, since it's a bit messy. You could squash some of them together, or we could do a squash-and-merge.

@illume illume changed the title Docs/vector epsilon Document pygame.math.Vector epsilon attribute Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs math pygame.math
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.

Document pygame.Vector2.epsilon and pygame.Vector3.epsilon
3 participants
@oddbookworm @Starbuck5 @ankith26