Skip to content

Fix half-cell voltage contributions #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2025
Merged

Fix half-cell voltage contributions #5139

merged 3 commits into from
Aug 1, 2025

Conversation

NicolaCourtier
Copy link
Contributor

Description

Update two negative electrode boundary values for the half-cell case where the negative electrode is planar.

Fixes #5124

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@NicolaCourtier NicolaCourtier marked this pull request as ready for review July 30, 2025 16:10
@NicolaCourtier NicolaCourtier requested a review from a team as a code owner July 30, 2025 16:10
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (773d9ca) to head (27ab8b7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5139      +/-   ##
===========================================
- Coverage    99.08%   99.08%   -0.01%     
===========================================
  Files          310      310              
  Lines        24460    24459       -1     
===========================================
- Hits         24237    24236       -1     
  Misses         223      223

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtimms rtimms enabled auto-merge (squash) August 1, 2025 11:13
@rtimms rtimms merged commit d421e3a into pybamm-team:develop Aug 1, 2025
21 of 22 checks passed
@NicolaCourtier NicolaCourtier deleted the 5124-half-cell-voltages branch August 1, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtimms rtimms rtimms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Voltage contributions in SPMe/DFN half-cell model
2 participants
@NicolaCourtier @rtimms